Do not assume shell for platform #254
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
win32 does not necessarily mean `cmd.exe` as well as others does not mean `sh`. Problem is, that previous functions, like s:escape_cword() do respect `shell` e.g. with `shellescape()`, but passing the arguments to `job_start()` / jobstart() does ignore `shell`. This leads to trouble. E.g. I use `fish`, where `shellescape()` escapes `\`, which means if <cword> / -cword is used (e.g. `Aword`), s:escape_cword() results to `\\bAword\\b` (which is correct), but this string is then passed to `jobstart()` executed by `sh`, which does not share the same escaping rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
win32 does not necessarily mean
cmd.exeas well as others does not meansh.Problem is, that previous functions, like s:escape_cword() do respect
shelle.g.with
shellescape(), but passing the arguments tojob_start()/jobstart()does ignore
shell.This leads to trouble. E.g. I use
fish, whereshellescape()escapes\, which meansif
<cword>/-cwordis used (e.g.Aword),s:escape_cword()results to\\bAword\\b(which is correct), but this string is then passed to
jobstart()executed bysh, which does not share the same escaping rules.