Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ic-toggle-button-group] - height of toggle buttons within groups does not match designs #2803

Open
lz405 opened this issue Nov 20, 2024 · 0 comments
Assignees
Labels
type: bug 🐛 Something isn't working

Comments

@lz405
Copy link
Contributor

lz405 commented Nov 20, 2024

Summary of the bug

When a toggle button is put into a group, the height of the buttons are inconsistent with designs and buttons outside of a toggle-button-group

🪜 How to reproduce

Tell us the steps to reproduce the problem:

  1. Add a toggle button group with toggle buttons inside it
  2. Notice the heights of the toggle buttons are inconsistent with figma designs

This also causes issues when they have the 'loading' prop, to recreate:

  1. Add a toggle button inside a toggle button group
  2. Give the toggle button the loading prop
  3. Notice the button that is loading has now changed in height

📸 Screenshots or code

Examples of the toggle button currently
image
image

🧐 Expected behaviour

Toggle buttons should remain consistent sizes whether they are in a group or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
Status: No status
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant