Cherry pick/radio group fix #2818
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/cherry-pick/radio-group-fix/web-components |
|
Cypress visual tests failed. |
GCHQ-Developer-299
approved these changes
Nov 25, 2024
GCHQ-Developer-299
requested changes
Nov 25, 2024
gd2910
force-pushed
the
cherry-pick/radio-group-fix
branch
2 times, most recently
from
baa92f1
to
4c3e3c6
Compare
…k event add a button under a radio option to show the onClick event works
gd2910
force-pushed
the
cherry-pick/radio-group-fix
branch
from
4c3e3c6
to
24eaf4e
Compare
cherry-pick
gd2910
force-pushed
the
cherry-pick/radio-group-fix
branch
from
24eaf4e
to
05f2483
Compare
|
Does not fix what we wanted it to, have written up a new ticket to look into the issue #2826 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Radio group cherry-pick
Related issue
See this merge for details