-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global enabled option so we can toggle it on and off for different tests #31
base: master
Are you sure you want to change the base?
Conversation
cf0aab8
to
e445c2c
Compare
It would be nice if we could simply call it |
e445c2c
to
423dc75
Compare
Organize tests a bit
…derstand what's going on
8ae5767
to
2582ca3
Compare
Amazing, I was just looking for this! I have some specific feature specs and VCR recordings that test that devise-pwned_password is working properly, but I only want to selectively enable it for these tests. The I will use your fork for now and try it out. UPDATE: This works perfectly! Thanks for your work! |
@michaelbanfield Sorry to bother you! But I'm just going through my Gemfile and looking at different forks I'm using, and I'm still using @TylerRick's branch for this PR. I was wondering if it might be possible to merge this and release a new version of the gem? If you are no longer maintaining the gem, then I'd be happy to take over maintenance and releasing new versions, since my company is using it (https://github.com/docspring). |
Update: We're still using this fork and would be keen to see support for this in the official release. But no worries if not! |
We also have cases where we are currently doing some less-than-elegant workarounds. For example, when seeding data, we skip all validations when creating users to avoid errors (since seed passwords tend to be pretty basic), and in our test suite we are using Let me know if there's anything I can do to help get this improvement released! We really appreciate your work on this gem @michaelbanfield! 🙏 |
Resolves #30
(Also resolves/supersedes #27)
Currently based on #29 but could be rebased.