-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Traditional Chinese support #121
Conversation
Hi @fshiori Thanks for your contribution. So far, the language codes in this library are ISO 639-1 codes.
Can we might use a ISO 639-3 language code listed here: https://en.wikipedia.org/wiki/ISO_639_macrolanguage#zho ? I'm not an expert on languages at all and need help here. |
Hello @michaelwittig Because Mandarin Chinese(ISO 639-1: zh/ ISO 639-3:cmn/BCP47: zh-Hans) and Taiwanese Mandarin(BCP47: zh-Hant)have different written word. |
I believe #47 is about entering a BCP47 code, and only use the first part before the |
#94 seems to solve the same use case |
I found this: |
Yes, #94 is solve the same use case. We can't only use ISO 639 to distinguish between simplified Chinese and traditional Chinese. In BCP47, it add script subtags use ISO 15924 code, so we can use use zh-Hant for traditional Chinese, use zh-Hans for simplified Chinese, and simple use zh for Chinese. |
I believe that switching from ISO 639-1 codes to BCP47 is more complicated.
|
need more work. |
I think you can extend the current language code to use IETF language tags https://en.wikipedia.org/wiki/IETF_language_tag en_us = US English zh_hk = Hong Kong Traditional Chinese |
We need to distinguish : |
Add Traditional Chinese support