Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add share button to submenu #670

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sevmonster
Copy link

Unless I'm missing something, there's no way to share the currently selected folder. I find this very inconvenient, especially that you can't share the toplevel folder without editing the database to point an existing link/insert a new link pointing to it.

No clue if this works, since when trying to make a test build, npm run build crashes for some reason:

% make build_frontend
make: *** [Makefile:10: build_frontend] Illegal instruction (core dumped)

% npm run build

> [email protected] build
> webpack

[1]    206949 illegal hardware instruction (core dumped)  npm run build

I have AVX512 disabled to fix an issue on my system so maybe that's it.

I know you prefer IRC to discuss changes, but I was curious and it seemed easy enough. Plus I'm not an IRC guy.

@mickael-kerjean
Copy link
Owner

Sorry for the delay, I've been entirely absorbed by the rewrite of the frontend. While I agree the current approach has limits, adding more option also comes with shortcomings. That's the general gist around the new release which you can installed using "CANARY=true", you can create plugins that will patch the frontend code with some new functionalities. Happy to help you along the way as frontend overrides plugin are the way to go for this kind of things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants