Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api gui howto guide #27

Merged
merged 75 commits into from
Sep 7, 2023
Merged

Api gui howto guide #27

merged 75 commits into from
Sep 7, 2023

Conversation

brynnz22
Copy link
Contributor

@mslarae13 @jkelliher-github here is a first draft of some api gui documentation aimed at data consumers. It just includes information and examples for the find and metadata endpoints. Please feel free to give lots of feedback or if its easier to make any edits directly!

Thanks!

Copy link
Contributor

@eecavanna eecavanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far! I've found it easy to read and digest (as someone who does have experience using Swagger UI, but doesn't have much—in some cases, any—experience with the endpoints covered).

I have only reviewed up to the beginning of the "Metadata Endpoints" section. I'll continue from there another day later today.

docs/howto_guides/api_gui.md Outdated Show resolved Hide resolved
docs/howto_guides/api_gui.md Outdated Show resolved Hide resolved
docs/howto_guides/api_gui.md Outdated Show resolved Hide resolved
docs/howto_guides/api_gui.md Outdated Show resolved Hide resolved
docs/howto_guides/api_gui.md Outdated Show resolved Hide resolved
docs/howto_guides/api_gui.md Outdated Show resolved Hide resolved
docs/howto_guides/api_gui.md Outdated Show resolved Hide resolved
docs/howto_guides/api_gui.md Show resolved Hide resolved
docs/howto_guides/api_gui.md Outdated Show resolved Hide resolved
docs/howto_guides/api_gui.md Outdated Show resolved Hide resolved
Copy link
Contributor

@eecavanna eecavanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finished reviewing the entire document as of commit 454fd99 (and as of commit a05a20e).

docs/howto_guides/api_gui.md Outdated Show resolved Hide resolved
docs/howto_guides/api_gui.md Outdated Show resolved Hide resolved
docs/howto_guides/api_gui.md Outdated Show resolved Hide resolved
docs/howto_guides/api_gui.md Outdated Show resolved Hide resolved
docs/howto_guides/api_gui.md Outdated Show resolved Hide resolved
docs/howto_guides/api_gui.md Outdated Show resolved Hide resolved
docs/howto_guides/api_gui.md Outdated Show resolved Hide resolved
docs/howto_guides/api_gui.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mslarae13 mslarae13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't really look for typos but have a few sentence re-work suggestions.

Also, we should consider who the documentation is for. I know we discussed it, but I don't recall the decision. And if the decision is both users & developers, we should separate out some of the developer / editing stuff to be more clear about who can have those permissions.. sections?

docs/howto_guides/api_gui.md Outdated Show resolved Hide resolved
docs/howto_guides/api_gui.md Outdated Show resolved Hide resolved
docs/howto_guides/api_gui.md Outdated Show resolved Hide resolved
docs/howto_guides/api_gui.md Outdated Show resolved Hide resolved
@brynnz22
Copy link
Contributor Author

@mslarae13 @dwinston @eecavanna @aclum I Incorporated all of your suggestions. Thank you all for your feedback! It was very helpful. I removed all of the POST endpoints regarding change sheets since after discussion with @mslarae13 this might be confusing for users who can't actually submit change sheets. The [documentation] that @dwinston (https://microbiomedata.github.io/nmdc-runtime/howto-guides/author-changesheets/) created for developers includes that information. I also implemented a spell checker so the typos should be fixed. Apologies for not doing this sooner, but thanks everyone for catching those! Please let me know of any other suggestions/feedback before I finalize this.

@aclum aclum merged commit ae70391 into main Sep 7, 2023
1 check failed
@aclum aclum deleted the api-gui-howto_guide branch September 7, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants