Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submission portal to mongo ETL code creating records with empty keys #711

Open
aclum opened this issue Oct 1, 2024 · 0 comments
Open

submission portal to mongo ETL code creating records with empty keys #711

aclum opened this issue Oct 1, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@aclum
Copy link
Contributor

aclum commented Oct 1, 2024

Describe the bug
I noticed keys with empty values the ecofab 2.0 ring trail data (nmdc:sty-11-ev70y104) for orcid, i checked the submission portal submission and it looks like these were not entered by the user. Best practice according to @turbomam is to exclude the key if the value is empty.

To Reproduce
Steps to reproduce the behavior:

  1. I am going to use changesheets to fix nmdc:sty-11-ev70y104 so best way to reproduce this would be to review the original output of the submission portal to mongo ETL code for nmdc:sty-11-ev70y104 or to make a new study and not fill out orcid for users other than the PI.

Expected behavior
A study_set record generated from submission portal to mongo should not have any keys with empty values.

Example user story template:
AS A system,
[INSTEAD OF keys with empty values]
I EXPECTED all keys to have values
[SO THAT we are following best practices]
[NO LATER THAN date unclear since several other processes that submit to mongo behave similarly.]

Screenshots
Screenshot 2024-10-01 at 4 49 46 PM

Acceptance Criteria

  • study_set records generated by submission portal to mongo ETL does not contain keys where the value is None, an empty quoted string, and empty array, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants