Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA uses Python 3.9 for building docs, but Python 3.10 for building package #2191

Open
eecavanna opened this issue Sep 27, 2024 · 2 comments
Labels
cleanup dependencies Pull requests that update a dependency file devops GH actions X SMALL Less than 8 hours, less than 1 day

Comments

@eecavanna
Copy link
Collaborator

Python 3.9

- name: Set up Python 3.
uses: actions/setup-python@v3
with:
python-version: 3.9

- name: Set up Python 3
uses: actions/setup-python@v4
with:
python-version: 3.9

Python 3.10

- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.10"

Commentary

I assume this was not intentional. I recommend using Python 3.10 for all three; or documenting why the docs-related ones are still using Python 3.9.

@eecavanna eecavanna added X SMALL Less than 8 hours, less than 1 day devops GH actions cleanup dependencies Pull requests that update a dependency file labels Sep 27, 2024
@eecavanna
Copy link
Collaborator Author

They each use a distinct version of the actions/setup-python action, too.

@turbomam
Copy link
Member

Nice catch @eecavanna

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup dependencies Pull requests that update a dependency file devops GH actions X SMALL Less than 8 hours, less than 1 day
Projects
None yet
Development

No branches or pull requests

2 participants