Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slot and enumeration to MetaproteomicsAnalysis to enable separate types of workflows #2256

Open
kheal opened this issue Nov 12, 2024 · 1 comment · May be fixed by #2276
Open

Add slot and enumeration to MetaproteomicsAnalysis to enable separate types of workflows #2256

kheal opened this issue Nov 12, 2024 · 1 comment · May be fixed by #2276
Assignees

Comments

@kheal
Copy link
Contributor

kheal commented Nov 12, 2024

The upcoming changes associated with MetaproteomicsAnalysis will result in two workflows that are inherently different, one that uses a metagenome that is a result of a DataGeneration process and one that uses a in-silico generated metagenome.

We want to increment these two types of workflows separately and for users to understand (from the WorkflowExecution record) which records are a result of which type of workflow. We also want individually-incremented ids for these workflows so users (and the data portal) do not assume that one is the "most recent".

Our solution is to add a required slot and associated enumeration to the MetaproteomicsAnalysis into class. This will make it clear which of the two workflows were used and allow for incrementing "re-runs" of the each type of workflow separately. All existing records would be migrated to use the enumeration that represents a MetaproteomicsAnalysis uses a metagenome that is a result of a DataGeneration process.

@kheal
Copy link
Contributor Author

kheal commented Nov 19, 2024

Should be in the schema by Dec 4th for the Dec 16th release (microbiomedata/issues#947)

@kheal kheal changed the title Make subclasses of MetaproteomicsAnalysis to enable separate types of workflows Add slot and enumeration to MetaproteomicsAnalysis to enable separate types of workflows Nov 26, 2024
@kheal kheal self-assigned this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant