Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find replacements for GENEPIO and OMIT mappings if possible and/or define prefixes #2258

Open
turbomam opened this issue Nov 12, 2024 · 1 comment

Comments

@turbomam
Copy link
Member

Thanks for providing these mappings, @aculm.

GENEPIO and OMIT aren't defined as prefixes yet. That's an error condition but it isn't super visible in the standard build process. We haven't used them before (although GENEPIO appears in an un-checked example in the mixs.yaml file). We should be conservative about adding new namespaces to the schema, especially if they aren't clearly authorities on the concepts being addressed.

Examples:

  members_id:
    range: string
    multivalued: true
    description: Names of the contigs that make up a metagenome-assembled genome.
    close_mappings:
      - GENEPIO:0100596

and

  num_5s:
    description: Number of 5s seqeuences detected, a subunit of ribosomes.
    range: integer
    minimum_value: 0
    broad_mappings:
      - OMIT:0013248
@eecavanna
Copy link
Collaborator

When I ran make squeaky-clean all test today in order to generate release artifacts for 11.1.0, I saw this at the end of the console output:

# ...
mkdir -p examples/output
poetry run linkml-run-examples \
        --schema nmdc_schema/nmdc_materialized_patterns.yaml \
        --input-directory src/data/valid \
        --counter-example-input-directory src/data/invalid \
        --output-directory examples/output > examples/output/README.md
Unrecognized prefix: GENEPIO
Unrecognized prefix: OMIT

The final two lines caught my eye. I think they are what @turbomam was referring to when he said this error currently "isn't super visible in the standard build process."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants