Fix results race condition #1056
Conversation
|
@naglepuff I tested this a lot but please do the same. I did not catch any odd numbers but definitely could have missed some. |
There was a problem hiding this comment.
I think this did the trick. To test, I compared this branch with the current dev code. I don't have the same data locally that exists in dev, but I was more interested in looking at network activity anyway, so I don't think it matters. I tested by running a search to get a URL with that search encoded, and then pointing my browser at that URL.
In dev, I see (and I think @jeffbaumes pointed this out in the original issue) two pairs of requests to the /search endpoints for biosample and study, which was the cause of the race condition:
With this branch, I only see a single pair of requests, and I see the expected results on the data portal:
fixes #1034