Add delete submission button and overflow menu #1446
Draft
+109
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marySalvi
reviewed
Nov 15, 2024
| <template #activator="{ on }"> | ||
| <v-btn | ||
| class="ml-1" | ||
| icon="mdi-dots-vertical" |
There was a problem hiding this comment.
I know you aren't done yet, but just wanted to point out that the icon prop is a boolean and doesn't take a string. It indicates a type of button, in this case round and 'text' (transparent). Therefore using the icon prop makes the text prop redundant.
Admittedly icon is not an intuitive name for this behavior.
There was a problem hiding this comment.
That makes a lot of sense why it was behaving unexpectedly. Thanks for pointing it out. I think that format is from vuetify 1 since I formatted it after those docs. I’m planning to go through and update all those kinds of things after looking at the vuetify2 docs some more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is linked to issue: microbiomedata/issues#826
The goal is to add a delete submission button inside an overflow menu that could be added to later.
Clicking the delete button will show a confirmation menu, and when confirmed the submission will be deleted from the front-end schema.