Unify behavior of study page filters #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naglepuff
changed the title
|
@jeffbaumes would you please review this pull request? I'm trying to determine what outstanding issues identified by GSP still need work. |
jeffbaumes
approved these changes
Aug 24, 2023
This properly filters the NMDC home page to only include the study of interest. This affects clicking on the omics type chips on a study page
naglepuff
force-pushed
the
unify-study-filter-links
branch
from
ad5736b
to
224e9de
Compare
|
Checked this branch again after rebasing off of main and verified that it works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #933
Previous Behavior:
When on a study page, if a user clicked the sample count, they would be taken back to the main data portal view, and the study list would be filtered to show only the study they were just looking at. If the user clicked one of the omics processing chips, they would be taken back to the main data portal view, and the study would be selected (indicated by the checkboxes next to the study titles). If a study is further down the list, the visual cue would be missing.
See linked issue for screenshots
New Behavior
Now, both actions produce the same result: a returning to the main data portal view with only the study of interest present in the studies list. If the user wants to see all studies, they have to remove the filter from the search sidebar.