Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect external activities #78

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Conversation

martinwork
Copy link
Collaborator

@martinwork martinwork commented Sep 9, 2024

@microbit-grace @microbit-matt-hillsdon I think this is ready for review and testing now.

@martinwork martinwork changed the title Protect external activities - DO NOT MERGE Protect external activities Sep 19, 2024
@microbit-grace microbit-grace self-requested a review September 25, 2024 09:25
Copy link
Collaborator

@microbit-grace microbit-grace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matt and I have tested the changes in this PR and it appears to work well!

We tested this version with a work profile by installing Test DPC via the Google Play store (https://developer.android.com/work/guide#testing).

To run this dev app on the phone's work profile via Android Studio, we added a new run configuration with the install flags as --user 10, where 10 is the user number. We found what the user number was via

$ adb shell pm list users                      
Users:
        UserInfo{0:Owner:c13} running
        UserInfo{10:Sample Managed Profile:10101030} running

@microbit-grace microbit-grace merged commit d1a49f7 into main Sep 25, 2024
1 check passed
@microbit-grace microbit-grace deleted the protect-external-activities branch September 25, 2024 09:34
@martinwork
Copy link
Collaborator Author

Thanks for the explanation @microbit-grace . I will try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants