Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new AccountsFragment to store accounts related prefs #2111

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

theimpulson
Copy link
Contributor

Summary

Add a new fragment to host preferences that concern accounts or data related to them.

  • Show currently logged-in accounts as a simple list on the top
  • Relocate add account preference below.
  • Add a new preference to open account settings page to manage all accounts quickly.

@theimpulson
Copy link
Contributor Author

@mar-v-in did you had a chance to take a look at this PR? Any suggestions on how can we open an individual account settings page (the one we discussed)?

@ale5000-git
Copy link
Member

ale5000-git commented Jan 2, 2024

I did a similar change before to "Add a new preference to open account settings page to manage all accounts quickly": micro5k@fe3be89

Account does have name in addition to type: https://developer.android.com/reference/android/accounts/Account.html#name
so I guess there may be also EXTRA_ACCOUNT_NAME but I haven't tried.

Add a new fragment to host preferences that concern accounts
or data related to them.

* Show currently logged in accounts as a simple list on top
* Relocate add account preference below.
* Add a new preference to quickly open account settings page to manage all accounts.

Issue: calyxos#712
Signed-off-by: Aayush Gupta <[email protected]>
Change-Id: Ifd00fe1295cc42077e835dd9afa829c444a5af97
@theimpulson
Copy link
Contributor Author

Rebased to fix merge conflict

@mar-v-in mar-v-in added this to the 0.3.1 milestone Mar 7, 2024
@mar-v-in mar-v-in merged commit 8c9aea5 into microg:master Mar 21, 2024
1 check passed
@theimpulson theimpulson deleted the accounts branch March 22, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants