Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding basic GridFS support #1962

Open
wants to merge 1 commit into
base: 4.7.x
Choose a base branch
from

Conversation

rohitkumbhar
Copy link
Contributor

@rohitkumbhar rohitkumbhar commented Jan 11, 2023

Adding basic GridFS support.

@dstepanov I'm not sure if it's desired to have it but I have opened a PR just in case it is.

@graemerocher graemerocher requested a review from dstepanov March 2, 2023 17:14
@dstepanov
Copy link
Contributor

Sorry for getting late to it. It looks good, but the configuration should be done to each Mongo Client defined. It might be better to contribute it to Micronaut MongoDB.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Stoorx
Copy link

Stoorx commented Sep 14, 2024

+1 to this PR (and the idea of GridFS support in general)

But I had a glance at the changes and I definitely do not like the way the files are up/downloaded from/to the local filesystem. I have checked how it is made in the Spring Framework, and they just use Input/OutputStreams. Maybe you (@rohitkumbhar) should take a look at the Spring Data code for some inspiration.

Also, (in response to @dstepanov's comment) I am not sure whether it is reasonable to move GridFS support to the micronaut-mongodb project, since it is more logically coupled with micronaur-data functionality. But I could mistake or misunderstand your point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants