Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated code for Micronaut Framework 5. #2843

Draft
wants to merge 7 commits into
base: 5.0.x
Choose a base branch
from
Draft

Remove deprecated code for Micronaut Framework 5. #2843

wants to merge 7 commits into from

Conversation

wetted
Copy link
Contributor

@wetted wetted commented Mar 19, 2024 •
edited
Loading

closes #2810

@wetted wetted added the type: breaking Introduces a breaking change label Mar 19, 2024
@wetted wetted self-assigned this Mar 19, 2024
@wetted
Copy link
Contributor Author

wetted commented Mar 19, 2024 •
edited
Loading

ping @dstepanov @sdelamo

I use a little help on this.

  • AbstractDataSourceTransactionManagerCondition doesn't compile if the the deprecated method is removed, but am unsure what all needs to be done here.
  • HibernateQuerySpec and HibernatePostgresQuerySpec tests are now failing. I have not yet investigated why.
  • Still need to add docs for breaking changes. I can work on that in the meantime.

wetted added 3 commits March 20, 2024 11:54
@wetted
Document breaking changes. [skip ci]
083036c
@wetted
Merge remote-tracking branch 'origin/master' into deprecations-for-mn5
d6233b5 
# Conflicts:
#	data-hibernate-jpa/src/test/java/io/micronaut/data/hibernate/BookRepository.java
#	data-model/src/main/java/io/micronaut/data/intercept/annotation/DataMethod.java
#	data-processor/src/main/java/io/micronaut/data/processor/visitors/finders/AbstractPatternMethodMatcher.java
#	gradle.properties
@wetted
Revert compile failing deprecation removal until alternative is deter…
29dd2f1 
…mined.
@wetted
Copy link
Contributor Author

wetted commented Apr 2, 2024

@dstepanov TODO:

micronaut-data/data-tx/src/main/java/io/micronaut/transaction/support/AbstractDataSourceTransactionManagerCondition.java

Line 67 in cd165f1

private Optional<String> transactionManagerProperty(@NonNull ConditionContext context,

@sdelamo sdelamo changed the base branch from 4.7.x to 5.0.x April 9, 2024 04:47
wetted added 2 commits April 17, 2024 09:29
@wetted
Merge remote-tracking branch 'refs/remotes/origin/5.0.x' into depreca…
7191c1b 
…tions-for-mn5

# Conflicts:
#	data-hibernate-jpa/src/test/java/io/micronaut/data/hibernate/BookRepository.java
@wetted
fix merge issues
435d064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dstepanov dstepanov

@sdelamo sdelamo

@wetted wetted

Labels
type: breaking Introduces a breaking change
Projects
5.0.0 Release
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Del @Deprecated Data
3 participants
@wetted @dstepanov @sdelamo