Log debug instead of warn when introspected entity cannot be mapped and falls back to mongo deserialize #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd falls back to mongo deserialize
radovanradic
commented
Dec 9, 2024
| @@ -168,8 +168,10 @@ protected <R> R convertResult(CodecRegistry codecRegistry, | |||
| try { | |||
| return mapIntrospectedObject(result, resultType); | |||
There was a problem hiding this comment.
What happens here is we get this map
which cannot be deserialized to the record
record CustomerView(@BsonId @BsonRepresentation(OBJECT_ID) String id, String firstName, String lastName) {
}
because _id and id are mismatched in introspected mapper. Therefore we catch exception and fallback to this code
else if (isDtoProjection) {
R dtoResult = MongoUtils.toValue(result.asDocument(), resultType, codecRegistry);
if (resultType.isInstance(dtoResult)) {
return dtoResult;
}
return conversionService.convertRequired(dtoResult, resultType);
}
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reported issue is not failing but just seeing logged warning. This PR keeps the same behavior added in #2950, adds test from the issue and changes log from warn to debug.