Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for resolveTemplate and resolveTemplates #342

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

timyates
Copy link
Contributor

This does not add support for the varients with encodeSlashInPath, nor the others. To support those, I believe we would need to rewrite this as the functionality differs from the core UriBuilder.

Unless requested, I'm not sure it's worth the extra work to do that at this time.

Fixes #247

This does not add support for the varients with encodeSlashInPath, nor the others.
To support those, I believe we would need to rewrite this as the functionality differs from the core UriBuilder.

Unless requested, I'm not sure it's worth the extra work to do that at this time.
@timyates timyates added the type: improvement A minor improvement to an existing feature label Aug 31, 2023
@timyates timyates added this to the 4.0.2 milestone Aug 31, 2023
@timyates timyates requested a review from sdelamo August 31, 2023 08:41
@timyates timyates self-assigned this Aug 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you

@sdelamo sdelamo merged commit e7c5909 into 4.0.x Aug 31, 2023
7 checks passed
@sdelamo sdelamo deleted the resolveTemplate branch August 31, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement A minor improvement to an existing feature
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants