fix: don’t leakage Micronaut Validation (#1267)

* fix: don’t leakage Micronaut Validation * test with hibernate validator * jakarta-valdiation-api as compileOnly
micronaut-projects · Feb 13, 2024 · 2dcf574 · 2dcf574
1 parent dc6181b
commit 2dcf574
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -68,7 +68,7 @@ sonar-gradle-plugin = "4.4.1.3373"
 micronaut-core = { module = 'io.micronaut:micronaut-core-bom', version.ref = 'micronaut' }
 
 # Platform catalogs
-
+micronaut-hibernate-validator = { module = "io.micronaut.beanvalidation:micronaut-hibernate-validator-bom", version.ref = "micronaut-hibernate-validator" }
 micronaut-cache = { module = "io.micronaut.cache:micronaut-cache-bom", version.ref = "micronaut-cache" }
 micronaut-data = { module = "io.micronaut.data:micronaut-data-bom", version.ref = "micronaut-data" }
 micronaut-micrometer = { module = "io.micronaut.micrometer:micronaut-micrometer-bom", version.ref = "micronaut-micrometer" }
@@ -80,9 +80,6 @@ micronaut-test = { module = "io.micronaut.test:micronaut-test-bom", version.ref
 micronaut-test-resources = { module = "io.micronaut.testresources:micronaut-test-resources-bom", version.ref = "micronaut-test-resources" }
 micronaut-validation = { module = "io.micronaut.validation:micronaut-validation-bom", version.ref = "micronaut-validation" }
 
-# Switch to BOM and catalog import when there's a bom
-micronaut-hibernate-validator = { module = "io.micronaut.beanvalidation:micronaut-hibernate-validator", version.ref = "micronaut-hibernate-validator" }
-
 # Vertx
 
 managed-vertx-sql-client = { module = "io.vertx:vertx-sql-client", version.ref = "managed-vertx" }

diff --git a/hibernate-jpa/build.gradle b/hibernate-jpa/build.gradle
@@ -7,7 +7,7 @@ dependencies {
 
     api(libs.managed.hibernate.core)
     api(libs.managed.jakarta.transaction.api)
-    api(mnValidation.micronaut.validation)
+    compileOnly(mnValidation.validation) // jakarta.validation:jakarta.validation-api
     compileOnly(mnData.micronaut.data.tx.hibernate)
     testImplementation(mnData.micronaut.data.tx.hibernate)
     api(mn.micronaut.aop)
@@ -28,6 +28,8 @@ dependencies {
     testImplementation(mnMicrometer.micronaut.micrometer.core)
     testImplementation(libs.managed.hibernate.micrometer)
 
+    testImplementation(mnHibernateValidator.micronaut.hibernate.validator)
+
     testRuntimeOnly projects.micronautJdbcTomcat
     testRuntimeOnly(libs.managed.h2)
 

diff --git a/hibernate-reactive/build.gradle b/hibernate-reactive/build.gradle
@@ -26,4 +26,5 @@ dependencies {
     testImplementation(mnTestResources.testcontainers.postgres)
     testImplementation libs.managed.vertx.pg.client
     testImplementation(mnData.micronaut.data.tx.hibernate)
+    testImplementation(mnValidation.micronaut.validation)
 }
diff --git a/settings.gradle b/settings.gradle
@@ -23,6 +23,7 @@ micronautBuild {
     importMicronautCatalog("micronaut-spring")
     importMicronautCatalog("micronaut-test-resources")
     importMicronautCatalog("micronaut-validation")
+    importMicronautCatalog("micronaut-hibernate-validator")
 }
 
 rootProject.name = 'sql-parent'