Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address #2539 by caching auth token #2720

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pharring
Copy link
Member

@pharring pharring commented Dec 7, 2022

Fix Issue #2539.

Changes

Cache the Authentication Token provided by CredentialEnvelope to improve performance and eliminate a continuous trace loop.

Introduce a CachedReflectionCredentialEnvelope class, derived from ReflectionCredentialEnvelope and use it when constructing the credential envelope in TelemetryConfiguration. The cached version will check if the cached auth token still has enough remaining lifetime (at least 5 minutes, by default) to be re-used.

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

@pharring pharring marked this pull request as ready for review December 7, 2022 21:53
@pharring
Copy link
Member Author

@TimothyMothra PTAL

@pharring
Copy link
Member Author

@TimothyMothra, PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant