Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swagger doc api path for oauth redirect #567

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

olivershen-wow
Copy link
Contributor

Description

Add swagger doc api path for oauth redirect.

Linked GitHub issue ID:

Pull Request Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Code compiles correctly with all tests are passed.
  • I've read the contributing guide and followed the recommended practices.
  • Wikis or README have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

If this introduces a breaking change for Hydra Lab users, please describe the impact and migration path.

  • Yes
  • No

How you tested it

Please make sure the change is tested, you can test it by adding UTs, do local test and share the screenshots, etc.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Technical design
  • Build related changes
  • Refactoring (no functional changes, no api changes)
  • Code style update (formatting, renaming) or Documentation content changes
  • Other (please describe): compliance scanning tool requirement

Feature UI screenshots or Technical design diagrams

If this is a relatively large or complex change, kick it off by drawing the tech design with PlantUML and explaining why you chose the solution you did and what alternatives you considered, etc...

@olivershen-wow olivershen-wow enabled auto-merge (squash) August 8, 2023 09:37
@olivershen-wow olivershen-wow disabled auto-merge August 8, 2023 09:42
@@ -96,6 +96,8 @@
} else {
response.sendRedirect(authUtil.getLoginUrl());
}
} else if (requestURI.equals(Const.FrontEndPath.SWAGGER_DOC_PATH)) {
response.sendRedirect(authUtil.getLoginUrl(requestURI, null));

Check warning

Code scanning / CodeQL

URL redirection from remote source

Untrusted URL redirection depends on a [user-provided value](1).
@olivershen-wow olivershen-wow enabled auto-merge (squash) August 8, 2023 09:47
@olivershen-wow olivershen-wow merged commit ed4f5d4 into main Aug 8, 2023
@olivershen-wow olivershen-wow deleted the user/lsh/fix-swagger-redirect-after-oauth branch August 8, 2023 10:07
olivershen-wow added a commit that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants