Merge pull request #615 from int19h/sympub

Publish symbols for builds to the public symbols server
microsoft · Jul 18, 2015 · 09edbce · 09edbce
2 parents e1289e9 + d33a9c3
commit 09edbce
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 12 deletions.
diff --git a/Build/BuildReleaseHelpers.psm1 b/Build/BuildReleaseHelpers.psm1
@@ -1,5 +1,5 @@
 function submit_symbols {
-    param($buildname, $buildid, $filetype, $sourcedir, $contacts)
+    param($productgroup, $productver, $buildname, $buildid, $buildnum, $buildtype, $filetype, $sourcedir, $reqdir, $contacts)
 
     $request = `
     "BuildId=$buildid $filetype
@@ -10,13 +10,23 @@ function submit_symbols {
     Project=TechnicalComputing
     Recursive=yes
     StatusMail=$contacts
-    UserName=$env:username"
+    UserName=$env:username
+    SubmitToArchive=all
+    SubmitToInternet=yes
+    ProductGroup=$productgroup
+    ProductName=$($productgroup)_$($productver)
+    Release=$buildnum
+    Build=$buildnum
+    BuildType=$buildtype
+    LocaleCode=en-US"
 
     Write-Output "*** Symbol Submission Text ***
 $request"
 
-    $request | Out-File -Encoding ascii -FilePath request_$filetype.txt
-    \\symbols\tools\createrequest.cmd -i request_$filetype.txt -d .\SymSrvRequestLogs -c -s
+    $reqfile = "$reqdir\symreq_$filetype.txt"
+    $request | Out-File -Encoding ascii -FilePath "$reqfile"
+
+    \\symbols\tools\createrequest.cmd -i "$reqfile" -d "$reqfile\SymSrvRequestLogs" -c -a
 }
 
 function _find_sdk_tool {

diff --git a/Build/BuildReleaseMockHelpers.psm1 b/Build/BuildReleaseMockHelpers.psm1
@@ -1,16 +1,31 @@
 function submit_symbols {
-    param($buildname, $buildid, $filetype, $sourcedir, $contacts)
+    param($productgroup, $productver, $buildname, $buildid, $buildnum, $buildtype, $filetype, $sourcedir, $reqdir, $contacts)
 
-    Write-Debug "*** Symbol Submission Text ***
-    BuildId=$buildid $filetype
+    $request = `
+    "BuildId=$buildid $filetype
     BuildLabPhone=7058786
     BuildRemark=$buildname
     ContactPeople=$contacts
     Directory=$sourcedir
     Project=TechnicalComputing
     Recursive=yes
     StatusMail=$contacts
-    UserName=$env:username"
+    UserName=$env:username
+    SubmitToArchive=all
+    SubmitToInternet=yes
+    ProductGroup=$productgroup
+    ProductName=$($productgroup)_$($productver)
+    Release=$buildnum
+    Build=$buildnum
+    BuildType=$buildtype
+    LocaleCode=en-US"
+
+    Write-Output "*** Symbol Submission Text ***
+$request"
+
+    # Dump it to the file as well so that it can be manually submitted for testing.
+    $reqfile = "$reqdir\symreq_$filetype.txt"
+    $request | Out-File -Encoding ascii -FilePath "$reqfile"
 }
 
 function _find_sdk_tool {

diff --git a/Python/Setup/BuildRelease.ps1 b/Python/Setup/BuildRelease.ps1
@@ -147,14 +147,17 @@ $setup_project = gi "$buildroot\Python\Setup\setup.proj"
 
 # Project metadata
 $project_name = "Python Tools for Visual Studio"
-$project_url = "http://pytools.codeplex.com"
+$project_url = "http://aka.ms/ptvs"
 $project_keywords = "PTVS; Visual Studio; Python"
 
+# Identifies all versions of the product for symbols archiving. No spaces.
+$product_group = "Python_Tools_for_Visual_Studio"
+
 # These people are able to approve code signing operations
 $approvers = "smortaz", "dinov", "stevdo", "pminaev", "gilbertw", "huvalo", "jinglou", "sitani", "crwilcox"
 
 # These people are the contacts for the symbols uploaded to the symbol server
-$symbol_contacts = "$env:username;dinov;smortaz;stevdo;gilbertw"
+$symbol_contacts = "$env:username;dinov;smortaz;stevdo;gilbertw;pminaev"
 
 # This single person or DL is the contact for virus scan notifications
 $vcs_contact = "ptvscore"
@@ -562,8 +565,9 @@ try {
                     Write-Output "Skipping symbol submission for $($i.VSName) because the build failed"
                     continue
                 }
-                submit_symbols "$project_name$spacename" "$buildnumber $($i.VSName)" "binaries" $i.signed_bindir $symbol_contacts
-                submit_symbols "$project_name$spacename" "$buildnumber $($i.VSName)" "symbols" $i.symboldir $symbol_contacts
+
+                submit_symbols "$product_group" "$release_version" "$project_name$spacename" "$buildnumber $($i.VSName)" "$buildnumber" "$config" "binaries" $i.signed_bindir $i.destdir $symbol_contacts
+                submit_symbols "$product_group" "$release_version" "$project_name$spacename" "$buildnumber $($i.VSName)" "$buildnumber" "$config" "symbols" $i.symboldir $i.destdir $symbol_contacts
 
                 $target_msbuild_options = msbuild-options $i
                 msbuild $global_msbuild_options $target_msbuild_options `