[PTRun] add support for UUIDv7 generation #35757
Open
+98
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
@microsoft-github-policy-service agree |
frederik-hoeft
changed the title
|
We will be upgrading to .net 9 shortly. I think they implemented the core logic here to create them. |
Oh, that's great news. Thanks for the heads-up. In that case I'll leave this PR on draft until I can switch out the core implementation with the one from .NET 9 😄 |
|
#35716 Is the PR for this |
|
@frederik-hoeft .net 9 PR is now in to the main. |
crutkas
added
the
Needs-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
PR Checklist
I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected-> was marked as Help WantedAdded on the required places-> nothing to addDetailed Description of the Pull Request / Additional comments
This PR implements UUIDv7 generation for PowerToys Run as defined in RFC 9562.
Validation Steps Performed
Added unit tests to ensure the version field is correctly set and to assert subsequently generated UUIDs are time-ordered. Performed manual testing using locally built x64 version of PT Run to ensure correct behavior.