Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New+ Windows 10 support #35832

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

cgaarden
Copy link
Contributor

@cgaarden cgaarden commented Nov 8, 2024

Summary of the Pull Request

This PR provides New+ support for Windows 10.

PR Checklist

Detailed Description of the Pull Request / Additional comments

  • Added Windows 10 support, without breaking Windows 11 support

Validation Steps Performed

Windows 10

  1. Installed on clean Windows 10 Home version (en_US)
  2. (test-signing is not needed)
  3. Desktop: Icon view: Tier 1 context menu New+ folder and files
  4. In folder on Desktop: Detailed view: Tier 1 context menu New+ folder and files
  5. Reviewed logs in NewPlus.ShellExtension\Logs\v0.0.1

Windows 11

  1. Installed on clean Windows 11 Sandbox (en_US)
  2. Manually test-signed
  3. Desktop: Icon view: Tier 1 context menu New+ folder and files
  4. In folder on Desktop: Detailed view: Tier 1 context menu New+ folder and files
  5. Reviewed logs in NewPlus.ShellExtension\Logs\v0.0.1

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@cgaarden cgaarden marked this pull request as ready for review November 10, 2024 04:23
@cgaarden cgaarden changed the title Windows 10 experimental support New+ Windows 10 support Nov 10, 2024

This comment has been minimized.

This comment has been minimized.

@jaimecbernardo
Copy link
Collaborator

Thank you for opening this PR. Right now fixing some stuff so I can get builds out of Dart CI to test, so I'll be pushing some commits 😄

@jaimecbernardo
Copy link
Collaborator

Currently trying to reduce telemetry calls, as I see one gets generated everytime I right-click on Desktop / any explorer window. Trying to reduce those ;)

@crutkas crutkas added Needs-Review This Pull Request awaits the review of a maintainer. in for .87 labels Nov 26, 2024
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks a lot for the contribution 😄

@jaimecbernardo jaimecbernardo added Good to Merge and removed Needs-Review This Pull Request awaits the review of a maintainer. labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants