Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer US English for system_category() messages, fall back to system locale, then ID 0 #5104

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Prefer US English for system_category() messages, fall back to system locale, then ID 0 #5104

wants to merge 9 commits into from
+26 −8

Commits on Nov 20, 2024

  1. Extract FormatMessageA flags for clarity.

    @StephanTLavavej
    StephanTLavavej committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    e56d32f View commit details
    Browse the repository at this point in the history

  2. Hardcode 0x0409, the language ID for "en-US".

    @StephanTLavavej
    StephanTLavavej committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    32a5e35 View commit details
    Browse the repository at this point in the history

  3. Add detailed explanation.

    @StephanTLavavej
    StephanTLavavej committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    2c72fed View commit details
    Browse the repository at this point in the history

  4. Cleanup: FormatMessageA returns DWORD, which is unsigned long, … 

    …but `auto` is simpler.
    @StephanTLavavej
    StephanTLavavej committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    6f3d866 View commit details
    Browse the repository at this point in the history

  5. Remove detailed explanation (will be reworked).

    @StephanTLavavej
    StephanTLavavej committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    7c1e1d9 View commit details
    Browse the repository at this point in the history

  6. Restore DWORD _Lang_id, make _Chars modifiable too.

    @StephanTLavavej
    StephanTLavavej committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    e64cd56 View commit details
    Browse the repository at this point in the history

  7. If US English fails, fall back to the existing system locale logic. 

    Co-authored-by: Jcr-dev <[email protected]>
    @StephanTLavavej @ycdev1
    StephanTLavavej and ycdev1 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    d7fd460 View commit details
    Browse the repository at this point in the history

  8. Comment the new technique.

    @StephanTLavavej
    StephanTLavavej committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    06384b7 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Make 3 attempts: US English, system locale, ID 0.

    @StephanTLavavej
    StephanTLavavej committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    6843272 View commit details
    Browse the repository at this point in the history