-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: New Event classes #235
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HakiRose I've also added a bunch of tests. This PR doesn't contain your modifications for text_generation nor verb_tense.
94a3fa1
to
866ce7d
Compare
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
==========================================
- Coverage 83.83% 82.28% -1.56%
==========================================
Files 62 57 -5
Lines 7976 7839 -137
==========================================
- Hits 6687 6450 -237
- Misses 1289 1389 +100
|
866ce7d
to
b2bda1a
Compare
b2bda1a
to
c79c96a
Compare
… the fully operating structure of the FW
…w quest/Event design, new world2inform7 structure, and more.
…opments on test files, some updates on the frame work, semi-final updates on Content Check Game, etc.
c79c96a
to
ec5185b
Compare
This PR allows Events to be combined using boolean expressions (e.g. and/or). This is needed to make more complex quests.
This PR closes #218.