-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create deprecatedjson from mdn web #884
Create deprecatedjson from mdn web #884
Conversation
Some QA:
Welcome to ask more question! Or is there somewhere I do not explain clearly enough? Just feel free to share your opinion! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please remove manualAnalytics/* and related changes.
…json-from-idlsource
@@ -281,6 +281,7 @@ __pycache__/ | |||
generated/ | |||
lib/ | |||
inputfiles/browser.webidl.json | |||
.vscode | |||
.vscode/* | |||
!.vscode/launch.template.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this does anything here 👀
@@ -0,0 +1,33 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any automatic generator for this file. Is this file handcrafted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it is created by a script. It is why I change the .gitignore file ---- I did add the template file, for running the script by vscode quickly.
But sandersn think this file would not update frequently and this file could be maintained manually like others. So I delete the script from the branch. You could see the previews for more info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We think this makes sense as-is 👍🏻
It only provides flags without the notes, so maybe still valuable! |
This is the first step to fix microsoft/TypeScript#39514.
Now mostly use MDN message.