Logging lcp target #607
Open
Logging lcp target #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ender336
reviewed
Sep 24, 2024
| @@ -42,6 +42,12 @@ export function max(metric: Metric, value: number): void { | |||
| } | |||
| } | |||
|
|
|||
| export function logTarget(event: Event, target: number): void { | |||
| if(event == Event.LargestPaintTarget){ | |||
ender336
reviewed
Sep 24, 2024
| @@ -81,6 +83,10 @@ function process(entries: PerformanceEntryList): void { | |||
| break; | |||
| case Constant.LCP: | |||
| if (visible) { metric.max(Metric.LargestPaint, entry.startTime); } | |||
| const targetNode = dom.get((entry as any).element)?.id | |||
| if(targetNode){ | |||
There was a problem hiding this comment.
nit, space between if and (
ender336
reviewed
Sep 24, 2024
| @@ -81,6 +83,10 @@ function process(entries: PerformanceEntryList): void { | |||
| break; | |||
| case Constant.LCP: | |||
| if (visible) { metric.max(Metric.LargestPaint, entry.startTime); } | |||
There was a problem hiding this comment.
do we want to only log targetNode if it is visible? not sure why we log the metric when visible, but the rest of it regardless
ender336
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.