-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove category usage from the poetry detector #991
Conversation
As of poetry 1.5.0 this field is no longer recorded in lockfiles: https://github.com/python-poetry/poetry/blob/master/CHANGELOG.md#150---2023-05-19
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #991 +/- ##
=======================================
- Coverage 75.3% 75.2% -0.1%
=======================================
Files 236 236
Lines 10325 10322 -3
Branches 1022 1022
=======================================
- Hits 7775 7772 -3
Misses 2267 2267
Partials 283 283 ☔ View full report in Codecov by Sentry. |
src/Microsoft.ComponentDetection.Detectors/poetry/PoetryComponentDetector.cs
Show resolved
Hide resolved
src/Microsoft.ComponentDetection.Detectors/poetry/PoetryComponentDetector.cs
Show resolved
Hide resolved
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
As of poetry 1.5.0 this field is no longer recorded in lockfiles: https://github.com/python-poetry/poetry/blob/master/CHANGELOG.md#150---2023-05-19
This causes the poetry detector to misclassify normal dependencies as dev dependencies, due to the existing logic of classifying dependencies as normal if and only if the category field is present and "main".
This follows the approach of #117, which conservatively adds all dependencies from the lockfile as normal dependencies lest dev dependencies be misclassified inadvertently.