feat: add option to log when the server is listening when waiting for client, so that clients can trigger attaching #1700
Conversation
… client, so that clients can trigger attaching
| @@ -325,6 +327,8 @@ def start_debugging(argv_0): | |||
| raise AssertionError(repr(options.mode)) | |||
|
|
|||
| if options.wait_for_client: | |||
| if options.log_on_listening: | |||
| print(f"Listening for debugger connection on {options.address[0]}:{options.address[1]}") | |||
There was a problem hiding this comment.
This seems like a one off. I'm wondering if there's another way to solve this that would be more generic. What if you set the log level and log to stderr? Would that work?
There was a problem hiding this comment.
If you did so you could put a log.debug here or something with a higher trace level so that it would only show up when the log level was high enough.
There was a problem hiding this comment.
Stupid question, but is there a way to set log level? The only logging options are log-to-stderr and log-to=[file], neither of which set level.
There was a problem hiding this comment.
log-to file seems to set the level to debug. I don't see a way to set the pydevd log level from debugpy besides that though. log-to-stderr does the same thing.
There was a problem hiding this comment.
Could you use log-to file and have the problem matcher read the file instead?
There was a problem hiding this comment.
No, problemMatcher doesn't support reading files. And that sounds like a more complex solution compared to the relatively reasonable/straightforward approach here.
There was a problem hiding this comment.
--log-to-stderr technically works, but prints ~260 lines of excess logs. IMO this log should be INFO or WARN, so how can I set stdout log level to info?
There was a problem hiding this comment.
Add another command line switch that sets the log level? --log-level=info?
This PR adds an option
--log-on-listeningto the CLI, whichprintsa message when waiting for client connection. This will allow clients (like VS Code) to trigger attaching only when a regex is matched.Please advise on the name of the option, as well as if there's a better way to log to stdout.