Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated pickers with input attribute compatibility. #33243

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Updated pickers with input attribute compatibility. #33243

wants to merge 16 commits into from

Conversation

tpalacino
Copy link

Previous Behavior

The Picker components that extend the BasePicker and BasePickerListBelow are missing properties that most other FluentUI user input component support. The missing properties include label, required, errorMessage, and onGetErrorMessage.

New Behavior

The pickers now support the following optional properties:

Property Description
label When specified renders consistently with how a label is rendered for a TextField.
required When specified renders consistently with how the required attribute is rendered for a TextField.
errorMessage When specified renders consistently with how an error message is rendered for a ComboBox.
onGetErrorMessage When specified behaves consistently with how an error message function behaves for a TextField.

Related Issue(s)

@tpalacino tpalacino mentioned this pull request Nov 10, 2024
Closed
@tpalacino tpalacino marked this pull request as ready for review November 16, 2024 13:49
@tpalacino tpalacino requested a review from a team as a code owner November 16, 2024 13:49
@tpalacino
Copy link
Author

@gouttierre @msft-fluent-ui-bot @JustSlone @layershifter @khmakoto @micahgodbolt Can someone please help me merge this?

@JustSlone JustSlone assigned tudorpopams and unassigned tudorpopams Nov 16, 2024
smhigley
smhigley requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@smhigley smhigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this work! I did an initial pass and left comments on stuff I saw. Let me know if they make sense, and if you have any questions!

packages/react/src/components/pickers/BasePicker.tsx Show resolved Hide resolved
packages/react/src/components/pickers/BasePicker.types.ts Outdated Show resolved Hide resolved
packages/react/src/components/pickers/BasePicker.tsx Outdated Show resolved Hide resolved
packages/react/src/components/pickers/BasePicker.tsx Outdated Show resolved Hide resolved
packages/react/src/components/pickers/BasePicker.tsx Outdated Show resolved Hide resolved
@tpalacino
Copy link
Author

@smhigley & @khmakoto Feedback has been resolved

khmakoto
khmakoto reviewed Nov 21, 2024
View reviewed changes
packages/react/src/components/pickers/BasePicker.types.ts Outdated Show resolved Hide resolved
packages/react/src/components/pickers/BasePicker.types.ts Outdated Show resolved Hide resolved
packages/react-examples/src/react/PeoplePicker/PeoplePicker.Normal.Example.tsx Outdated Show resolved Hide resolved
packages/react-examples/src/react/PeoplePicker/PeoplePicker.Normal.Example.tsx Outdated Show resolved Hide resolved
packages/react-examples/src/react/PeoplePicker/PeoplePicker.List.Example.tsx Outdated Show resolved Hide resolved
packages/react-examples/src/react/PeoplePicker/PeoplePicker.List.Example.tsx Outdated Show resolved Hide resolved
packages/react-examples/src/react/PeoplePicker/PeoplePicker.Normal.Example.tsx Outdated Show resolved Hide resolved
packages/react-examples/src/react/PeoplePicker/PeoplePicker.List.Example.tsx Outdated Show resolved Hide resolved
khmakoto
khmakoto reviewed Nov 21, 2024
View reviewed changes
packages/react/src/components/pickers/BasePicker.tsx Outdated Show resolved Hide resolved
packages/react/src/components/pickers/BasePicker.tsx Outdated Show resolved Hide resolved
packages/react/src/components/pickers/BasePicker.tsx Outdated Show resolved Hide resolved
packages/react/src/components/pickers/BasePicker.tsx Outdated Show resolved Hide resolved
packages/react/src/components/pickers/BasePicker.tsx Outdated Show resolved Hide resolved
packages/react/src/components/pickers/BasePicker.tsx Outdated Show resolved Hide resolved
packages/react/src/components/pickers/BasePicker.tsx Outdated Show resolved Hide resolved
packages/react/src/components/pickers/BasePicker.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khmakoto khmakoto khmakoto left review comments

@smhigley smhigley smhigley requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Component: Pickers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NormalPeoplePicker required attribute
4 participants
@tpalacino @smhigley @khmakoto @tudorpopams