Add pqueue to API #692
pelikhanAnnotations
3 errors
|
build:
packages/core/src/concurrency.ts#L22
There is no error handling in the PLimitPromiseQueue class. If any of the promises in the queue fail, it could lead to unhandled promise rejections which can cause the Node.js process to crash. Consider adding try-catch blocks or .catch() handlers to handle promise rejections.
|
|
build:
packages/core/src/constants.ts#L245
The values for CHAT_REQUEST_PER_MODEL_CONCURRENT_LIMIT and PROMISE_QUEUE_CONCURRENCY_DEFAULT are hard-coded. This could lead to scalability issues if these values need to be adjusted based on the environment or other factors. Consider making these values configurable through environment variables or a configuration file.
|
|
build:
packages/core/src/types/prompt_template.d.ts#L2241
The value for containerPort has been changed from "80/tcp" to "8000/tcp". This could be a breaking change if there are other services or configurations that depend on the containerPort being "80/tcp". Ensure that this change is communicated to all stakeholders and that any dependent services or configurations are updated accordingly.
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
genai-results
|
27.1 KB |
|