Skip to content
genai pull request commit review

Add pqueue to API #693

Sign in to view logs

Add pqueue to API

Add pqueue to API #693

Triggered via pull request September 25, 2024 14:23
@pelikhanpelikhan
synchronize #725
pqueue
Status Success
Total duration 1m 36s
Artifacts 1

genai-pr-commit-review.yml

on: pull_request
build
1m 22s
build
Fit to window
Zoom out
Zoom in

Annotations

3 errors
build: packages/core/src/concurrency.ts#L22
There is no error handling in the PLimitPromiseQueue class. If any of the promises in the queue fail, it will cause an unhandled promise rejection.
build: packages/core/src/types/prompt_template.d.ts#L2281
The `mapAll` method in the `PromiseQueue` interface is missing a return type. It should specify that it returns a `Promise<ReturnType[]>`.
build: packages/core/src/constants.ts#L245
The values for `CHAT_REQUEST_PER_MODEL_CONCURRENT_LIMIT` and `PROMISE_QUEUE_CONCURRENCY_DEFAULT` are hardcoded. Consider making these configurable through environment variables or a configuration file.

Artifacts

Produced during runtime
Name Size
genai-results
25.4 KB