Add basic support for Google AI models #1148
Annotations
3 errors
|
genaiscript pr-review-commit:
packages/core/src/chat.ts#L821
The expression `genOptions.logprobs || top_logprobs > 0 ? true : undefined` may not work as intended due to operator precedence. Consider using parentheses to clarify the logic.
|
|
genaiscript pr-review-commit:
packages/core/src/connection.ts#L294
The base URL for the Google API is hardcoded. Consider making it configurable to enhance flexibility and adaptability.
|
|
genaiscript pr-review-commit:
packages/core/src/fetch.ts#L166
The `curl` command is missing quotes around the URL, which could lead to issues if the URL contains special characters.
|
Loading