always regen description

microsoft · Jun 5, 2024 · 7a753a2 · 7a753a2
1 parent fecdf76
commit 7a753a2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/.github/workflows/genai-pr-review.yml b/.github/workflows/genai-pr-review.yml
@@ -1,7 +1,6 @@
 name: genai pull request review
 on:
     pull_request:
-        types: [ready_for_review]
         paths:
             - yarn.lock
             - ".github/workflows/ollama.yml"

diff --git a/packages/core/src/github.ts b/packages/core/src/github.ts
@@ -68,6 +68,7 @@ export async function githubUpdatePullRequestDescription(
     commentTag: string
 ) {
     const { apiUrl, repository, issue } = info
+    assert(commentTag)
 
     if (!issue) return { updated: false, statusText: "missing issue number" }
     const token = await host.readSecret(GITHUB_TOKEN)
@@ -89,15 +90,21 @@ export async function githubUpdatePullRequestDescription(
     const resGetJson = (await resGet.json()) as { body: string }
     let { body } = resGetJson
     if (!body) body = ""
-    const tag = `\n\n<!-- genaiscript begin ${commentTag} -->\n\n`
-    const endTag = `\n\n<!-- genaiscript end ${commentTag} -->\n\n`
+    const tag = `<!-- genaiscript begin ${commentTag} -->`
+    const endTag = `<!-- genaiscript end ${commentTag} -->`
+    const sep = "\n\n"
 
     const start = body.indexOf(tag)
     const end = body.indexOf(endTag)
     if (start > -1 && end > -1 && start < end) {
-        body = body.slice(0, start + tag.length) + text + body.slice(end)
+        body =
+            body.slice(0, start + tag.length) +
+            sep +
+            text +
+            sep +
+            body.slice(end)
     } else {
-        body = body + tag + text + endTag
+        body = body + sep + tag + sep + text + sep + endTag + sep
     }
 
     const res = await fetch(url, {