-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unique pr comment #512
Merged
Merged
Unique pr comment #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concerns:
Suggested code fixes and improvements:
// In githubCreateIssueComment, before appending the tag:
if (!body.includes(tag)) {
body = `${body}\n\n${tag}\n\n`;
} If these concerns are addressed, then it would be "LGTM π".
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI Changes
--pull-request-comment
and--pull-request-description
options now create comments with a unique id, defaulting to the script id.--no-pull-request-reviews-cache
option has been removed.Library Changes
githubUpdatePullRequestDescription
function to include unique comment tags and improved the logic for updating the pull request description.githubCreatePullRequestReviews
function.githubCreateIssueComment
function to sort comments by the last updated and to avoid duplication when creating new comments.