-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
curl escape #534
curl escape #534
Conversation
The changes in the GIT_DIFF indicate that the Concerns:
Suggestion:
Given that the changes are related to command-line execution and not directly to TypeScript code functionality, and assuming the escaping has been properly tested, the changes look good. Response: LGTM 🚀
|
@@ -130,12 +130,12 @@ export const OpenAIChatCompletion: ChatCompletionHandler = async ( | |||
|
|||
trace.detailsFenced( | |||
`✉️ fetch`, | |||
`curl ${url} \\ | |||
`curl -X POST ${url} \\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The curl command should specify the -X POST
method to ensure the request is sent as a POST request. Great catch on updating this! 👍
generated by pr-review-commit
@@ -14,7 +14,9 @@ The reviewer can also suggest changes to the code, documentation, or other files | |||
|
|||
The output of the LLM is inserted as a comment in the pull request conversation | |||
(and updated as needed to avoid duplicates). | |||
Here is an [example](https://github.com/microsoft/genaiscript/pull/504#issuecomment-2145273728) in the GenAIScript repository. | |||
|
|||
Here is an [pull request](https://github.com/microsoft/genaiscript/pull/534) in the GenAIScript repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link text "pull request" should be more descriptive to improve accessibility and SEO. Consider changing it to "example pull request in the GenAIScript repository".
generated by pr-docs-review-commit
Fix JSON escaping of curl commands
curl
command in the script has been modified to explicitly use thePOST
method by adding-X POST
.-d
option ofcurl
is now being sanitized to escape single quotes properly, ensuring that the JSON string is correctly formatted for the shell command.