centralize vscode.Uri usage

[pelikhan]

• The vscode.Uri.parse function now includes a second argument, true, which allows parsing of URLs with strict mode enabled. This change affects multiple files including browser.ts, state.ts, and vshost.ts. 🌐
• The applyEdits function in edit.ts now accepts an additional argument, state, which is an instance of ExtensionState. This change also affects the way URIs are created in the function. 📝
• The activateFragmentCommands function in fragmentcommands.ts and other similar functions now use the host.toUri method to create URIs instead of vscode.Uri.file. This change is also reflected in multiple other files. 🔄
• The ExtensionState class in state.ts has been significantly refactored. A large block of error handling code has been removed, and the saveScripts and applyEdits methods now use the host.toUri method. 🧹
• The activateStatusBar function in statusbar.ts now uses the host property of state to create URIs. 📊
• The activateTestController function in testcontroller.ts now uses the host.toUri method to create URIs. 🎮
• A new method, toUri, has been added to the VSCodeHost class in vshost.ts. This method creates a vscode.Uri from a filename or URL. 🆕

In summary, these changes seem to centralize the creation of URIs in the VSCodeHost class, making the code more maintainable and consistent. 🎯

generated by pr-describe

[pelikhan]

/describe

[pelikhan]

/genai-describe

[pelikhan]

/genai-describe

[pelikhan]

/genai-review

[pelikhan]

/genai-review

[pelikhan]

/genai-review

[github-actions]

The changes in the GIT_DIFF show that the developer is refactoring the code to use a new method toUri from the host object to create URIs instead of using vscode.Uri.file. This is a good change as it centralizes the URI creation logic in one place, making the code more maintainable.

However, there is a potential issue with the toUri method. It checks if the input string is an absolute path or a URL, but it does not handle relative paths. If a relative path is passed to this method, it will be treated as an absolute path, which could lead to incorrect URIs.

Here is a suggested fix:

toUri(filenameOrUrl: string): vscode.Uri {
    const folder = this.projectUri;
    if (!filenameOrUrl) return folder;
    if (/^[a-z][a-z0-9+\-.]*:\/\//.test(filenameOrUrl))
        return vscode.Uri.parse(filenameOrUrl, true);
    if (this.path.isAbsolute(filenameOrUrl))
        return vscode.Uri.file(filenameOrUrl);
    else return vscode.Uri.file(path.join(folder.fsPath, filenameOrUrl));
}

This fix uses the path.join method to correctly handle relative paths.

Other than this issue, the changes look good. The developer has also removed some commented-out code, which is a good practice as it keeps the codebase clean.

So, with the above fix, LGTM 🚀

generated by pr-review