Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook support #540
Notebook support #540
Changes from 23 commits
d84f2ea
a72a6d3
53e1770
822c7a0
a0938d4
39aa76a
ffd846b
014f432
594bfe6
2448509
8dc1ab1
401b655
de91212
d852a5d
aabb146
f109ba3
19cf5c0
46749ee
8208352
940f4d6
4ac7224
a1c2481
2105d42
ec218b1
bde4ac2
b172da9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The template string function is incorrectly represented as
$``...```. It should be
${...}` to correctly denote a template literal in JavaScript.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code block starting on line 50 should specify the language for syntax highlighting. It should be
js instead of
js title="poem.genai.js".There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
wrap
attribute in the markdown code block is unnecessary and not standard markdown syntax.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code block starting on line 54 should specify the language for syntax highlighting. It should be
md instead of
md title="🤖" wrap. Additionally, the "wrap" option is not standard and may not be recognized by the renderer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code fence for the markdown block is incorrectly formatted; it should not include the title and wrap annotations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
project
getter method has been removed from theFragment
class but there is no replacement provided. If other parts of the codebase are using this method, this will cause a breakage.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import of
dedent
has been changed fromts-dedent
to./indent
. If the implementation ofdedent
in./indent
is different fromts-dedent
, this could potentially introduce bugs.Large diffs are not rendered by default.