Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrated alert preview #593

Merged
merged 1 commit into from
Jul 29, 2024
Merged

integrated alert preview #593

merged 1 commit into from
Jul 29, 2024

Conversation

pelikhan
Copy link
Member

@pelikhan pelikhan commented Jul 29, 2024

built in markdown alert rendering

  • The markdown CSS in packages/vscode/markdown.css has seen significant additions. Several CSS variables for color scheme have been introduced, accommodating both light and dark modes. 🌓
  • Various classes related to .markdown-alert have been introduced, most likely for future alert styles, with each alert type having a unique border left color and title color. These classes include markdown-alert-note, markdown-alert-important, markdown-alert-warning, markdown-alert-tip, and markdown-alert-caution. 🚨
  • In the package.json of packages/vscode/package.json, a new markdown plugin has been added to the contributions - markdown.markdownItPlugins. A dependency markdown-it-github-alerts has also been added to the package. The addition of these points towards future support for GitHub styled markdown alerts. 📝
  • In packages/vscode/src/extension.ts, a new function extendMarkdownIt has been introduced which uses MarkdownItGitHubAlerts. This probably means that markdown will now support the rendering of GitHub styled alerts. 🔔
  • There doesn't seem to be any user-facing changes in terms of the public API.

generated by pr-describe

Copy link

LGTM 🚀

The changes in GIT_DIFF look good. It seems that the developer has added a markdown feature (MarkdownItGitHubAlerts) to the software. This would extend the functionalities of the markdown editor, presumably allowing it to parse and display Github-style alerts. This could enhance readability and user experience. As long as the new packages (MarkdownIt and MarkdownItGitHubAlerts) do not have any compatibility issues with the existing project and they have been properly installed, this change should be fine.

generated by pr-review

@pelikhan pelikhan merged commit 1c02f0e into main Jul 29, 2024
9 checks passed
@pelikhan pelikhan deleted the markdown-alerts branch July 29, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant