-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display and check server version #610
Conversation
pelikhan
commented
Aug 8, 2024
•
edited by github-actions
bot
Loading
edited by github-actions
bot
- Documentation updates 📝: Adjusted some instructions and code snippets for clarity in "docs/src/content/docs/reference/cli/index.mdx". This should make it easier for users to follow along.
- Dependency changes 🗃️: Removed dependency '@types/semver' and 'semver' from the CLI's package.json and integrated them within the core's package.json. This reduces redundancy.
- Code restructuring 🏗️: The method for comparing semantic versioning (semver) is now managed centrally in a new file 'packages/core/src/semver.ts'. This creates a more reusable codebase.
- Codebase enhancements 🛠️: Made adjustments in 'packages/core/src/server/client.ts' and 'vscode/src/servermanager.ts' to handle version checking better, including checking against outdated versions of the command line tool. This should help enforce best practices among users.
- Build/CI process 🏗️: The CLI tool no longer prompts the user for confirmation before execution. This change should optimize the continuous integration (CI) scenario.
|
||
Check that your node version is at least 20._ and npm 10._ by running this command. | ||
- Check that your node version is at least 20._ and npm 10._ by running this command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version placeholders are incomplete; please specify the exact versions required.
generated by pr-docs-review-commit
version_placeholder
|
||
```sh "--yes" | ||
npx --yes genaiscript ... | ||
``` | ||
|
||
You can also lock this call to a particular version. | ||
- Specify the version range to avoid unexpected behavior with cached installations of the CLI using npx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version specification should be more precise to ensure reproducibility.
generated by pr-docs-review-commit
version_specification
@@ -166,7 +166,6 @@ export interface ChatChunk extends RequestMessage { | |||
|
|||
export type RequestMessages = | |||
| ServerKill | |||
| ServerVersion | |||
| ServerEnv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate import of ServerVersion
. This can lead to confusion and unnecessary code. Please remove the duplicate import. 🧹
generated by pr-review-commit
duplicate_import
The changes in the GIT_DIFF involve the following:
There's no clear functional issue, but some observations can be made:
Without more context, it's difficult to flag specific concerns. However, these changes do not seem to introduce any major functional issues. Accordingly, my response would be: "LGTM 🚀"
|