Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for working with markdown front matter #642
Support for working with markdown front matter #642
Changes from 3 commits
3edf564
f0f2b0f
2c51740
fdef72c
c010f50
3decda2
da03986
aef318b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 45 in packages/core/src/frontmatter.ts
GitHub Actions / build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default case in the switch statement throws an error for unsupported formats. However, the function does not handle this error, which could lead to unhandled exceptions. Consider providing a default format or handling this error in a way that does not interrupt the execution of the program. 😊
Check failure on line 65 in packages/core/src/frontmatter.ts
GitHub Actions / build
Check failure on line 150 in packages/core/src/markdown.ts
GitHub Actions / build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no null check for the
splitMarkdown
function result. If this function returns null or undefined, it could lead to a runtime error when trying to destructurefrontmatter
andcontent
. Consider adding a null check before destructuring the result. 🛠️