Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runPrompt to import list and create new script for llm-as-expert with Rush albums filter and sorting logic #695

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

pelikhan
Copy link
Member

@pelikhan pelikhan commented Sep 6, 2024

"This pull request adds the 'runPrompt' function to the import list in the 'importPrompt' module. It also creates a new script called 'llm-as-expert.genai.mts' which includes logic for filtering and sorting Rush albums released in the 1980s. The script uses the 'gpt-3.5' model for filtering and sorting options, and the 'gpt-4o' model for validation. The changes aim to enhance the functionality of the project by providing a more efficient and organized way to work with Rush albums."

  • 🚀 Addition of a new run prompt in the 'importPrompt' function in 'importprompt.ts'. This suggests an enhancement in the existing functionality, possibly offering a new way to execute prompts.
  • 📇 Creation of a new file 'llm-as-expert.genai.mts', which might be used to test or showcase the use of the 'openai:gpt-4o' model. It has some interesting things going on:
    • 🎵 Defining of a new data array 'rushAlbums', which lists various Rush albums. This would be helpful in any use-cases related to the discography of Rush.
    • 🛠️ Declaration of two new tools, 'llm-gpt35' and 'llm-4o', for using the GPT-3.5-Turbo and GPT-4o models respectively in Language Learning Model (LLM) requests. This could mean the platform is expanding its repertoire of language models.
    • 💼 Included use-cases for these models: filtering and sorting a list of Rush albums released in the 1980's, then validating the results.

Please note that the changes have no direct impact on the public API as defined in the files "packages/core/src/prompt_template.d.ts" and "packages/core/src/prompt_type.ts".

generated by pr-describe

Copy link

github-actions bot commented Sep 6, 2024

The changes in GIT_DIFF add a new string "runPrompt" to the array inside the importPrompt function. This appears to be an enhancement, probably adding a new operation or action that can be performed.

As the changes are minimal and do not seem to break anything, it looks good to me.

So, LGTM 🚀.

generated by pr-review

@@ -25,6 +25,7 @@ export async function importPrompt(
"retrieval",
"fetchText",
"cancel",
"runPrompt",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function "runPrompt" is added to the array but its definition is not found in the changes. Please ensure that this function is defined elsewhere in your code. 🧐

generated by pr-review-commit missing_function_definition

@@ -25,6 +25,7 @@ export async function importPrompt(
"retrieval",
"fetchText",
"cancel",
"runPrompt",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "runPrompt" function is added to the array but it's not used anywhere in the changes. Please make sure to use it or remove it if it's not necessary. 😊

generated by pr-review-commit unused_array_item

@@ -25,6 +25,7 @@ export async function importPrompt(
"retrieval",
"fetchText",
"cancel",
"runPrompt",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of "runPrompt" function in the array seems to be a new feature. Please ensure to add tests for this new functionality to maintain the code quality. 🧪

generated by pr-review-commit missing_test

@pelikhan pelikhan merged commit 6b95752 into main Sep 6, 2024
11 checks passed
@pelikhan pelikhan deleted the run-prompt-context branch September 6, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant