-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add runPrompt to import list and create new script for llm-as-expert with Rush albums filter and sorting logic #695
Conversation
…with Rush albums filter and sorting logic
The changes in GIT_DIFF add a new string "runPrompt" to the array inside the As the changes are minimal and do not seem to break anything, it looks good to me. So, LGTM 🚀.
|
@@ -25,6 +25,7 @@ export async function importPrompt( | |||
"retrieval", | |||
"fetchText", | |||
"cancel", | |||
"runPrompt", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function "runPrompt" is added to the array but its definition is not found in the changes. Please ensure that this function is defined elsewhere in your code. 🧐
generated by pr-review-commit
missing_function_definition
@@ -25,6 +25,7 @@ export async function importPrompt( | |||
"retrieval", | |||
"fetchText", | |||
"cancel", | |||
"runPrompt", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "runPrompt" function is added to the array but it's not used anywhere in the changes. Please make sure to use it or remove it if it's not necessary. 😊
generated by pr-review-commit
unused_array_item
@@ -25,6 +25,7 @@ export async function importPrompt( | |||
"retrieval", | |||
"fetchText", | |||
"cancel", | |||
"runPrompt", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of "runPrompt" function in the array seems to be a new feature. Please ensure to add tests for this new functionality to maintain the code quality. 🧪
generated by pr-review-commit
missing_test
"This pull request adds the 'runPrompt' function to the import list in the 'importPrompt' module. It also creates a new script called 'llm-as-expert.genai.mts' which includes logic for filtering and sorting Rush albums released in the 1980s. The script uses the 'gpt-3.5' model for filtering and sorting options, and the 'gpt-4o' model for validation. The changes aim to enhance the functionality of the project by providing a more efficient and organized way to work with Rush albums."
Please note that the changes have no direct impact on the public API as defined in the files "packages/core/src/prompt_template.d.ts" and "packages/core/src/prompt_type.ts".