-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor runPrompt usage and remove fetchText and cancel from import prompts #700
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1555,9 +1555,13 @@ | |
): void | ||
defFileOutput( | ||
pattern: string, | ||
description?: string, | ||
options?: FileOutputOptions | ||
): void | ||
runPrompt( | ||
generator: string | PromptGenerator, | ||
options?: PromptGeneratorOptions | ||
): Promise<RunPromptResult> | ||
Check failure on line 1564 in packages/core/src/types/prompt_template.d.ts GitHub Actions / build
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The function
|
||
} | ||
|
||
interface GenerationOutput { | ||
|
@@ -2256,17 +2260,13 @@ | |
* Force disconnect network | ||
*/ | ||
disconnect(): Promise<void> | ||
} | ||
|
||
interface PromptContext extends ChatGenerationContext { | ||
script(options: PromptArgs): void | ||
system(options: PromptSystemArgs): void | ||
defFileMerge(fn: FileMergeHandler): void | ||
defOutputProcessor(fn: PromptOutputProcessorHandler): void | ||
Check failure on line 2269 in packages/core/src/types/prompt_template.d.ts GitHub Actions / build
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The function
|
||
runPrompt( | ||
generator: string | PromptGenerator, | ||
options?: PromptGeneratorOptions | ||
): Promise<RunPromptResult> | ||
env: ExpansionVariables | ||
path: Path | ||
parsers: Parsers | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functions
fetchText
andcancel
have been removed. If these functions are being used elsewhere in the code, this could lead to undefined function errors. Please ensure that these functions are either not being used elsewhere, or that appropriate replacements have been provided. 🕵️♀️