Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refcatoring assembly of messages #794

Merged
merged 11 commits into from
Oct 24, 2024
Merged

refcatoring assembly of messages #794

merged 11 commits into from
Oct 24, 2024

Conversation

pelikhan
Copy link
Member

@pelikhan pelikhan commented Oct 24, 2024


Pull Request Description

Summary of Changes

Workflow Enhancements

  • 🛠️ GitHub Workflows: Added continue-on-error: true to the genai-pr-commit-review and genai-pr-docs-commit-review steps to allow workflows to proceed even if these steps fail.
  • 🐳 Docker: Updated the ollama workflow to use ollama:phi3.5 model instead of ollama:phi3.
  • 🚀 Playwright Workflow: Added a step to download and run the ollama Docker container. Updated the browse-text step to use the ollama:phi3.5 model.

Dependency Updates

  • 📦 CLI Package: Updated es-toolkit to ^1.26.0 and openai to ^4.68.4.
  • 📦 Core Package: Updated es-toolkit to ^1.26.0 and openai to ^4.68.4.
  • 📦 VSCode Package: Updated es-toolkit to ^1.26.0.
  • 📦 Sample Package: Updated zod-to-json-schema to ^3.23.5.

Code Improvements

  • 🧩 Message Handling: Introduced functions to append user, assistant, and system messages to chat contexts.
  • 🛠️ Error Handling: Added NotSupportedError for unsupported system message types.
  • 📝 Schema Documentation: Enhanced documentation to specify that schema identifiers must be added in the code fence header for JSON, YAML, or CSV sections.
  • 🔄 Refactoring: Refactored the renderPromptNode and expandTemplate functions to improve message handling and system message integration.

Documentation

  • 📚 System Schema: Renamed system.schema.genai.js to system.schema.genai.mjs and added documentation for code sections with schema identifiers.

Samples

  • 🆕 New Script: Added a new script writetext.genai.mjs in the sample package to demonstrate the usage of the writeText function for different roles.

These changes aim to enhance workflow robustness, update dependencies for improved functionality, and refactor code for better maintainability and readability.

generated by prd

Copy link

Investigator report

, aa65e9e

generated by gai

@pelikhan pelikhan marked this pull request as ready for review October 24, 2024 18:47
@pelikhan pelikhan merged commit 69015fb into main Oct 24, 2024
7 of 9 checks passed
@pelikhan pelikhan deleted the multimodel branch October 24, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant