Filter errors from environment information output #857
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| if (!token && !/^http:\/\//i.test(base)) | ||
| // localhost typically requires no key | ||
| throw new Error("OPENAI_API_KEY missing") |
There was a problem hiding this comment.
The code throws an error if the OPENAI_API_KEY is missing, but it doesn't check if the base is a valid URL before this. This could lead to an error being thrown for the wrong reason. Consider checking the validity of base before throwing an error for a missing API key. 🔑
generated by pr-review-commit
missing_key_check
| @@ -237,16 +248,6 @@ export const MODEL_PROVIDERS = Object.freeze([ | |||
| detail: "LiteLLM proxy", | |||
| url: DOCS_CONFIGURATION_LITELLM_URL, | |||
| }, | |||
There was a problem hiding this comment.
The MODEL_PROVIDERS array contains duplicate entries for MODEL_PROVIDER_ANTHROPIC and MODEL_PROVIDER_HUGGINGFACE. This could lead to confusion or unexpected behavior when iterating over providers. Please ensure each provider is listed only once. 🔄
generated by pr-review-commit
duplicate_model_providers
| res.providers.push({ | ||
| provider: modelProvider.id, | ||
| error: errorMessage(e), | ||
| }) |
There was a problem hiding this comment.
The error handling logic inside the envInfo function only pushes errors to the result if the error option is set. This might lead to silent failures if the option is not set. Consider logging or handling errors in a way that ensures they are not completely ignored. 🚨
generated by pr-review-commit
error_handling
|
The changes in the GIT_DIFF include:
These changes enhance the functionality by providing more control over CLI options, improve code readability, and ensure the system supports additional model providers. LGTM 🚀
|
Introduce an option to display errors when showing environment information, enhancing the command-line interface for better error visibility.
-e, --errorto the CLI command for showing.envinformation, allowing users to display errors encountered during the operation.envInfofunction to handle the newerroroption, capturing and storing any errors related to provider information.parseTokenFromEnvfunction by removing redundant code for improved readability.MODEL_PROVIDERSconstant list to include “Anthropic models” and “Hugging Face models” in a more consistent order.