-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: ♻️ refine JSON schema typing and processing #918
Conversation
Investigator report
|
LGTM 🚀 The changes in the pull request look reasonable and well-structured. The addition of Here's a brief summary of the key changes:
These changes should help in building more robust and maintainable JSON Schema definitions, making it easier to handle complex data structures. If there are any further questions or additional changes required, feel free to let me know! 🤝
|
<|im_start|>
|
{
"runs": [
{
"run_id": 12187858738,
"job_name": "genai investigator",
"status": "",
"conclusion": null,
"head_sha": "90170a1471ba837aab24c634090089efb172d563"
},
{
"run_id": 12187845078,
"job_name": "ollama smoke tests",
"status": "success",
"conclusion": null,
"head_sha": "18eaac168f27454a7cb3e7f6986bec36e8c815b6"
},
{
"run_id": 12187845068,
"job_name": "playwright smoke tests",
"status": "success",
"conclusion": null,
"head_sha": "18eaac168f27454a7cb3e7f6986bec36e8c815b6"
},
{
"run_id": 12187845079,
"job_name": "build",
"status": "success",
"conclusion": null,
"head_sha": "18eaac168f27454a7cb3e7f6986bec36e8c815b6"
},
{
"run_id": 12187845090,
"job_name": "genai pull request commit review",
"status": "success",
"conclusion": null,
"head_sha": "18eaac168f27454a7cb3e7f6986bec36e8c815b6"
},
{
"run_id": 12187844589,
"job_name": "PR #918",
"status": "success",
"conclusion": null,
"head_sha": "18eaac168f27454a7cb3e7f6986bec36e8c815b6"
},
{
"run_id": 12187828346,
"job_name": "genai pull request commit review",
"status": "success",
"conclusion": null,
"head_sha": "49e9d3c0f70784449fa42992bcd5aed33d179e53"
},
{
"run_id": 12187828339,
"job_name": "playwright smoke tests",
"status": "cancelled",
"conclusion": null,
"head_sha": "49e9d3c0f70784449fa42992bcd5aed33d179e53"
},
{
"run_id": 12187828338,
"job_name": "build",
"status": "failure",
"conclusion": null,
"head_sha": "49e9d3c0f70784449fa42992bcd5aed33d179e53"
},
{
"run_id": 12187828332,
"job_name": "ollama smoke tests",
"status": "cancelled",
"conclusion": null,
"head_sha": "49e9d3c0f70784449fa42992bcd5aed33d179e53"
},
{
"run_id": 12187827927,
"job_name": "PR #918",
"status": "success",
"conclusion": null,
"head_sha": "49e9d3c0f70784449fa42992bcd5aed33d179e53"
},
{
"run_id": 12187798898,
"job_name": "genai pull request commit review",
"status": "success",
"conclusion": null,
"head_sha": "49e9d3c0f70784449fa42992bcd5aed33d179e53"
},
{
"run_id": 12187798998,
"job_name": "GitHub Actions workflow",
"status": "completed",
"conclusion": "success",
"head_sha": "62ffc9ac07c045ecbde31a23d5e9bebaabc04fe8"
}
]
}
|
Fix for #913
JSONSchemaType
now includesnull
JSONSchemaDescripted
for common properties likedescription
JSONSchemaAnyOf
allows complex schemas to be defined using theanyOf
keyword, enabling more flexibility in what types can be acceptedJSONSchemaString
,JSONSchemaNumber
,JSONSchemaBoolean
, andJSONSchemaObject
by extending them fromJSONSchemaDescripted
, which now includes a commondescription
property with an optional type