-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Astro5.0 #950
Conversation
@@ -6,7 +6,7 @@ description: Learn how to automate reviewing issues with a script. | |||
keywords: pull request automation, code review, GitHub Actions, GenAIScript reviewer, PR feedback | |||
--- | |||
import { Code } from '@astrojs/starlight/components'; | |||
import importedCode from "../../../../../packages/sample/genaisrc/issue-reviewer.genai?raw" | |||
import importedCode from "../../../../../packages/sample/genaisrc/issue-reviewer.genai.mjs?raw" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import statement should use the .mjs
extension to indicate that it is a module.
generated by pr-docs-review-commit
import_extension
import { docsSchema } from "@astrojs/starlight/schema" | ||
import { blogSchema } from "starlight-blog/schema" | ||
|
||
export const collections = { | ||
docs: defineCollection({ | ||
loader: docsLoader(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docsLoader
is imported but not used in the defineCollection
function. Consider removing it if it's not needed.
generated by pr-review-commit
loader_not_used
@@ -8,7 +8,7 @@ import { getCollection } from "astro:content" | |||
export const getStaticPaths = (async () => { | |||
const entries = await getCollection("docs") | |||
return entries.map((entry) => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using entry.id
instead of entry.slug
might lead to confusion since id
is typically used for unique identifiers and slug
for URLs. Ensure this change aligns with your project's conventions.
generated by pr-review-commit
id_vs_slug
@@ -8,7 +8,7 @@ import { getCollection } from "astro:content" | |||
export const getStaticPaths = (async () => { | |||
const entries = await getCollection("docs") | |||
return entries.map((entry) => ({ | |||
params: { entry: entry.slug }, | |||
params: { entry: entry.id }, | |||
props: { entry }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The props
object is defined but not used in the return statement. Consider removing it if it's not needed.
generated by pr-review-commit
props_not_used
waiting on blog
🔍 High-Level Summary of Changes
Changed Dependencies
astro
moved from^4.16.16
to^5.0.5
es-toolkit
moved from various versions (like^1.30.0
) to^1.30.1
Updated Imports
issue-reviewer.mdx
:../../../../../packages/sample/genaisrc/issue-reviewer.genai?raw
to../../../../../packages/sample/genaisrc/issue-reviewer.genai.mjs?raw
Package.json Update
cli
,core
,vscode
), the dependency fores-toolkit
is updated to version^1.30.1
.Potential Impact
These updates appear aimed at maintaining or improving the project's dependencies, potentially enhancing functionality and security.